[PATCH] D82164: [flang] Port test_any.sh tests to FileCheck: Hand port tests which use regexes
Richard Barton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 22 09:07:41 PDT 2020
richard.barton.arm added a comment.
> Should there be two (maybe 3?) RUN: lines? One to test STRICT_F18 and another for ARCHAIC_FORTRAN?
Agreed. I have added a line that defines -DSTRICT_F18 and runs with -Mstandard. ARCHAIC_FORTRAN is a superset of the current run line, so I think two run lines should be sufficient.
Note that the test has issues in that it checks for "error:" but the parser diagnostics that are emitted do not start with this. Because of this, the test misses the fact that even without -Mstandard, there is a diagnostic emitted on one of the testcases.
I propose the fix for this test is a separate change.
> With these changes we can remove test_any.sh, right?
Agreed. I thought about pushing these in a sequence as one would with a github PR, but figured as they did not actually depend on eachother I would submit them as separate phab reviews. I propose to edit the last commit that gets approved with a `git rm` on that file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82164/new/
https://reviews.llvm.org/D82164
More information about the llvm-commits
mailing list