[PATCH] D43620: [Pipeliner] Fixed node order issue related to zero latency edges

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 08:35:22 PDT 2020


danilaml added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/MachinePipeliner.cpp:3951
+      unsigned SuccIndex =
+          std::get<1>(*std::lower_bound(Indices.begin(), Indices.end(),
+                                        std::make_pair(SuccSU, 0), CompareKey));
----------------
danilaml wrote:
> Is this dereference always valid? Can SuccSU unit be exit su and not be part of the NodeOrder?
Nvm, this. I see that this issue has been already fixed upstream.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43620/new/

https://reviews.llvm.org/D43620





More information about the llvm-commits mailing list