[PATCH] D78901: [Support] Get process statistics in ExecuteAndWait and Wait

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Support/Program.h:60
+    std::chrono::microseconds UserTime;
+    uint64_t PeakMemory = 0;
+  };
----------------
I believe a comment indicating the unit of measure used with the value (looks like KiB to me) should be added.


================
Comment at: llvm/lib/Support/Unix/Program.inc:364
   do {
-    WaitResult.Pid = waitpid(ChildPid, &status, WaitPidOptions);
+    WaitResult.Pid = wait4(ChildPid, &status, WaitPidOptions, &Info);
   } while (WaitUntilTerminates && WaitResult.Pid == -1 && errno == EINTR);
----------------
sepavloff wrote:
> hubert.reinterpretcast wrote:
> > Noting here that the functionality in not available on AIX via this BSD interface. Are there plans to increase dependency on this functionality? As it is, our builds are broken.
> I created D82282 with workaround. Could you please check if it works? I don't have access to AIX.
Thank you; I'm checking it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78901/new/

https://reviews.llvm.org/D78901