[PATCH] D77565: [AArch64] Remove implicit landing pads.

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss marked 3 inline comments as done.
danielkiss added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64BranchTargets.cpp:134
+      if (Subtarget.hasV8_3aOps()) {
+        // PACI[A|B] LR, SP performs the same operation but it is not a landing
+        // pad.
----------------
chill wrote:
> Why not create the `PACI[AB]` from the very start, with a comment why are we doing it?
> 
Just replacing them here is a why more simpler code.
I won't change the generated code if BTI is not on. 


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:941
+    if (ShouldSignWithAKey(MF)) {
+      if (Subtarget.hasV8_3aOps()) {
+        BuildMI(MBB, MBBI, DL, TII->get(AArch64::PACIA))
----------------
chill wrote:
> Could this be refactored in a separate function and shared with the similar code that signs outlined functions?
> 
I'm going to create a new patch that removes the code duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77565/new/

https://reviews.llvm.org/D77565