[PATCH] D82197: [NFCI] Cleanup range checks in Register/MCRegister
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 22 08:02:15 PDT 2020
daltenty marked an inline comment as done.
daltenty added inline comments.
================
Comment at: llvm/include/llvm/MC/MCRegister.h:39
+ static_assert(sizeof(Reg) >= 4, "Reg isn't large enough to hold full range.");
+ static constexpr unsigned NoRegister = 0u;
+ static constexpr unsigned FirstPhysicalReg = 1u;
----------------
hubert.reinterpretcast wrote:
> Would `NullValue` be correct?
Used `NoRegister` to be consistent with what TableGen calls this value.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82197/new/
https://reviews.llvm.org/D82197
More information about the llvm-commits
mailing list