[PATCH] D82300: [unittest, ADT] Add unit tests for itostr & utostr

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 07:30:18 PDT 2020


thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: llvm/unittests/ADT/StringExtrasTest.cpp:198
+
+  EXPECT_EQ("-0", utostr(0, /*isNeg=*/true));
+  EXPECT_EQ("-1", utostr(1, /*isNeg=*/true));
----------------
Since there's no comment, I'm not sure whether it is supported by the API or not. I'd be tempted to add an assert and a comment not to support it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82300/new/

https://reviews.llvm.org/D82300





More information about the llvm-commits mailing list