[PATCH] D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando updated this revision to Diff 272375.
Orlando marked 6 inline comments as done.
Orlando added a comment.

Addressed comments from @aprantl

To continue to scope-bytes-covered conversation a little further: Even if we did report the coverage stat correctly (i.e. only parent scope bytes covered count) we'd still see slightly different results. There's at least one <https://github.com/llvm/llvm-project/blob/master/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp#L1576> place I can think of where some special case code is triggered because of the fewer number of location ranges.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82129/new/

https://reviews.llvm.org/D82129

Files:
  llvm/include/llvm/CodeGen/DbgEntityHistoryCalculator.h
  llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
  llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
  llvm/test/DebugInfo/ARM/PR26163.ll
  llvm/test/DebugInfo/COFF/register-variables.ll
  llvm/test/DebugInfo/X86/live-debug-variables.ll
  llvm/test/DebugInfo/X86/trim-var-locs.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82129.272375.patch
Type: text/x-patch
Size: 20704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200622/05b98a35/attachment-0001.bin>