[PATCH] D82275: [DWARFYAML][debug_info] Add support for error handling.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 02:06:31 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: llvm/lib/ObjectYAML/DWARFVisitor.h:16
 #include "llvm/BinaryFormat/Dwarf.h"
+#include "llvm/Support/Error.h"
 #include "llvm/Support/MemoryBuffer.h"
----------------
Could you forward declare `Error` here, rather than having an extra include?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82275/new/

https://reviews.llvm.org/D82275





More information about the llvm-commits mailing list