[PATCH] D82173: [DWARFYAML][debug_info] Use 'AbbrCode' to index the abbreviation.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 02:06:30 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, thanks.



================
Comment at: llvm/lib/ObjectYAML/DWARFVisitor.cpp:60
+      if (AbbrCode > DebugInfo.AbbrevDecls.size())
+        // TODO: Report and test this error.
+        report_fatal_error("abbrev code must be less than the number of "
----------------
I'd change "Report" to "Handle", since the error is now being reported (although not in the best way).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82173/new/

https://reviews.llvm.org/D82173





More information about the llvm-commits mailing list