[PATCH] D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction
rithik sharma via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 22 06:25:48 PDT 2020
RithikSharma marked an inline comment as done.
RithikSharma added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:308
+bool llvm::isSafeToMove(Instruction &I) {
+ if (!(isa<LoadInst>(I) || isa<StoreInst>(I) || isa<CallInst>(I) ||
+ isa<FenceInst>(I) || isa<CastInst>(I) || isa<UnaryOperator>(I) ||
----------------
These conditions are inherited from LICM, is this a generalized safe assumption? Is there any very obvious exception to this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82290/new/
https://reviews.llvm.org/D82290
More information about the llvm-commits
mailing list