[PATCH] D80713: [AMDGPU] Support disassembly for AMDGPU kernel descriptors

Mon Jun 22 06:57:45 PDT 2020

madhur13490 added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:1255
+
+MCDisassembler::DecodeStatus AMDGPUDisassembler::decodeKernelDescriptor(
+    StringRef KdName, ArrayRef<uint8_t> Bytes, uint64_t KdAddress) const {
----------------
rochauha wrote:
> madhur13490 wrote:
> > Can you please have function in reverse order? E.g."onSymbolStart" calls "decodeKernelDescriptor" so latter should be above former. This way it's readable and and at a predictable location. Ideally, callees should be above callers.
> I was under the impression that having the current order of functions helps to 'incrementally zoom' into the details while reading the code.
No, You can see other files e.g. runOn* functions are always at the bottom. It is also important for compiler as it would see declarations/definitions before callers. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80713/new/

https://reviews.llvm.org/D80713