[PATCH] D82295: [IR] Short-circuit comparison with itself for Attributes

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 06:57:43 PDT 2020


danilaml marked an inline comment as done.
danilaml added inline comments.


================
Comment at: llvm/lib/IR/Attributes.cpp:613
     if (AI.isTypeAttribute()) {
       assert(getKindAsEnum() != AI.getKindAsEnum() &&
              "Comparison of types would be unstable");
----------------
This avoids potential assert here (which can be triggered when glibc tests irreflexivity with expensive checks enabled).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82295/new/

https://reviews.llvm.org/D82295





More information about the llvm-commits mailing list