[PATCH] D82200: [ADT] Fix itostr handling of min int64_t value

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 06:57:42 PDT 2020


jhenderson added a comment.

In D82200#2106412 <https://reviews.llvm.org/D82200#2106412>, @thopre wrote:

> In D82200#2105987 <https://reviews.llvm.org/D82200#2105987>, @jhenderson wrote:
>
> > Shouldn't there be some unit testing for this? It seems like a better testing method than relying on an UBSan build bot failure that might not manifest again in the future if some other testing were changed.
>
>
> Will do, mind if I add you as reviewer?


That's fine by me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82200/new/

https://reviews.llvm.org/D82200





More information about the llvm-commits mailing list