[PATCH] D82201: [llvm-readobj] - Validate the DT_STRSZ value to avoid crash.

Mon Jun 22 03:43:09 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:485-486
+  - StName:  0xffffff00
+## An arbitrary valid symbol to document we report an error before dumping it.
+  - StName:  0x1
+ProgramHeaders:
----------------
grimar wrote:
> jhenderson wrote:
> > This comment implies you should have a check showing we don't dump the next symbol, but I don't see such a check.
> > 
> > I'd expect to see some sort of `-NOT` line after the error to show that we don't dump the next symbol.
> I check the "error:..." line. Which currently means the application terminates.
> If we had a warning, I'd use something like `-NOT`.
> 
> Does it makes sense?
It makes sense, but I therefore don't think we need this symbol currently.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82201/new/

https://reviews.llvm.org/D82201