[PATCH] D82200: [ADT] Fix itostr handling of min int64_t value

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 01:01:56 PDT 2020


jhenderson added a comment.

Shouldn't there be some unit testing for this? It seems like a better testing method than relying on an UBSan build bot failure that might not manifest again in the future if some other testing were changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82200/new/

https://reviews.llvm.org/D82200





More information about the llvm-commits mailing list