[PATCH] D81894: [llvm-readobj][COFF] add .llvm.call-graph-profile section dump

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Of course, even better than using assembly might be to extend yaml2obj for COFF to support this section type with a unique syntax, but that's probably outside the scope of this patch, so assembly is probably fine.



================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile.test:39-47
+    #                ^-------                                                                                         from symbol index (4-byte)
+    #                        ^-------                                                                                 to symbol index (4-byte)
+    #                                ^---------------                                                                 weight (8-byte)
+    #                                                ^-------                                                         from symbol index (4-byte)
+    #                                                        ^-------                                                 to symbol index (4-byte)
+    #                                                                ^---------------                                 weight (8-byte)
+    #                                                                                ^-------                         from symbol index (4-byte)
----------------
It would probably be easier to follow for me if the description immediately followed the arrow, i.e:
```
    #                ^------- from symbol index (4-byte)
    #                        ^------- to symbol index (4-byte)
```

(Somewhat moot if switching to assembly though)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81894/new/

https://reviews.llvm.org/D81894