[PATCH] D82276: Make ninja smart console builds more pretty

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 21 22:13:36 PDT 2020


phosek added a comment.

In D82276#2105872 <https://reviews.llvm.org/D82276#2105872>, @mehdi_amini wrote:

> OK I see now, the description wasn't clear to me earlier. So it is about the fact that `find_package` failure is multiple-lines long, and it is called separately from LLVM, clang, lld, and lldb. Instead we will still display 4 times the warning but it'll be one line instead, right?
>
> Seems like we could also call this once only from the LLVM CMakeLists.txt and make the variables available to the subprojects?


I think that would be better. The current setup predates monorepo where LLVM, clang, lld and lldb were in separate repositories, but now when they're in the same repository, there's no reason to invoke `get_source_info` multiple times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82276/new/

https://reviews.llvm.org/D82276





More information about the llvm-commits mailing list