[PATCH] D82276: Make ninja smart console builds more pretty

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki created this revision.
davezarzycki added reviewers: tstellar, phosek, mehdi_amini.
davezarzycki added a project: LLVM.
Herald added a subscriber: mgorny.

CMake's `find_package` outputs to the console on success, which confuses the smart console mode of the `ninja` build system. Let's quiet the success message and manually warn instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82276

Files:
  llvm/cmake/modules/VersionFromVCS.cmake


Index: llvm/cmake/modules/VersionFromVCS.cmake
===================================================================
--- llvm/cmake/modules/VersionFromVCS.cmake
+++ llvm/cmake/modules/VersionFromVCS.cmake
@@ -4,7 +4,7 @@
 # extra argument, otherwise uses CMAKE_CURRENT_SOURCE_DIR).
 
 function(get_source_info path revision repository)
-  find_package(Git)
+  find_package(Git QUIET)
   if(GIT_FOUND)
     execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --git-dir
       WORKING_DIRECTORY ${path}
@@ -45,5 +45,7 @@
         set(${repository} ${path} PARENT_SCOPE)
       endif()
     endif()
+  else()
+    message(WARNING "Git not found. Version cannot be determined.")
   endif()
 endfunction()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82276.272303.patch
Type: text/x-patch
Size: 699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200621/08695f1f/attachment.bin>