[PATCH] D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning

[Stefan Agner via Phabricator via llvm-commits]

falstaff84 added a comment.

In D59733#1441197 <https://reviews.llvm.org/D59733#1441197>, @peter.smith wrote:

> From what I can see the mrc in venum_read_pmresr() is not a VFP/Neon instruction. It hails from arch/arm/kernel/perf_event_v7.c and is specific to Qualcomm's Scorpion and Krait CPUs. My understanding is that CP15 is used for the PMU in v7, it is possible that the use of p10 there is a mistake but I'm not knowledgeable enough about Scorpion and Krait to know whether this is the case.


Yeah not sure, I tried to research the origin of this code, and it seems to be there since quite a while (and also got refactored over time). I assume this code has been used and is working.

> You'll need to update test/MC/ARM/diagnostics.s  as this is currently failing with this patch as it tests whether the old error message is being produced. You can run the tests from the build directory with make/ninja check-llvm. To run an individual test with output then from the build dir: bin/llvm-lit -v -a  /path/to/llvm/test/MC/ARM/diagnostics.s

Updated this test and another failing test in `llvm/test/MC/ARM/coprocessors.s`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59733/new/

https://reviews.llvm.org/D59733