[PATCH] D82049: Fix crash in VectorCombine when attempting to peephole ConstantVector sequences

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D82049#2104821 <https://reviews.llvm.org/D82049#2104821>, @clin1 wrote:

> Our internal test passes---thank you for the fix.


Thanks for spotting the bug! If you still want to make the change to 'return true' if we find a constant folding opportunity, I think that would be fine to do. But we should change the variable name from 'MadeChange' to something like 'NeedsCleanup' to not be confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82049/new/

https://reviews.llvm.org/D82049