[PATCH] D80713: [AMDGPU] Support disassembly for AMDGPU kernel descriptors

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl requested changes to this revision.
kzhuravl added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:1587-1600
+  KdStream << Indent << ".amdhsa_exception_fp_ieee_invalid_op "
+           << ((FourByteBuffer >> 24) & (uint32_t)1) << "\n";
+  KdStream << Indent << ".amdhsa_exception_fp_denorm_src "
+           << ((FourByteBuffer >> 25) & (uint32_t)1) << "\n";
+  KdStream << Indent << ".amdhsa_exception_fp_ieee_div_zero "
+           << ((FourByteBuffer >> 26) & (uint32_t)1) << "\n";
+  KdStream << Indent << ".amdhsa_exception_fp_ieee_overflow "
----------------
Don't use bare numbers. Use enums defined in https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1399-1414
+      // if (Obj->isELF() && Obj->getArch() == Triple::amdgcn) {
+      //   if (Symbols[SI].Type == ELF::STT_AMDGPU_HSA_KERNEL) {
+      //     // skip amd_kernel_code_t at the begining of kernel symbol (256
+      //     bytes) Start += 256;
+      //   }
+      //   if (SI == SE - 1 ||
+      //       Symbols[SI + 1].Type == ELF::STT_AMDGPU_HSA_KERNEL) {
----------------
Why is this commented out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80713/new/

https://reviews.llvm.org/D80713