[PATCH] D82072: [InstCombine] Combile select & Phi by same condition

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 20 03:40:21 PDT 2020


nikic added a comment.

I'm probably missing something here, but wouldn't it be possible to phi-translate IfTrue and IfFalse (`Inputs[Pred] = IfTrue->DoPHITranslation(BB, Pred)` etc) and the existing code would already work? Why perform the conversion to a different select first, rather than going directly to the phi? (That should also be more powerful, because it removes the limitation that you need a single value.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82072/new/

https://reviews.llvm.org/D82072





More information about the llvm-commits mailing list