[PATCH] D82228: [flang] Add BoxValue (part of upstreaming flang lowering)

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.

A general word about boxes might be useful.



================
Comment at: flang/include/flang/Lower/Support/BoxValue.h:49-51
+  mlir::Value getAddr() const { return addr; }
+
+  mlir::Value addr;
----------------
Why does this structure use a get Function for a member of the struct? Could this be a class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82228/new/

https://reviews.llvm.org/D82228