[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:891
 
 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones
 
----------------
echristo wrote:
> MaskRay wrote:
> > echristo wrote:
> > > MaskRay wrote:
> > > > echristo wrote:
> > > > > I'd remove the uses of blacklist and whitelist here and below. Just have the language and the documentation be for the new option.
> > > > `clang-tblgen -gen-opt-docs` does not seem to provide a feature to hide an option. HelpHidden does not hide the option.
> > > Please remove blacklist and whitelist from the option description.
> > I can do that but the next person updating the documentation will add them back.
> > 
> > I believe `clang-tblgen -gen-opt-docs` just doesn't have the feature. Maybe we can delete the old options earlier so that we don't need to worry about the documentation.
> Ugh. Yes, I hope so too. Can you raise it on cfe-dev?
I can but I need to understand more about `clang-tblgen -gen-opt-docs` first...

Very few people know how to regenerate the doc I think... 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82244/new/

https://reviews.llvm.org/D82244