[PATCH] D82232: Add hasNItemsOrLess and container variants of hasNItems and friends

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 17:24:02 PDT 2020


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:1948
+/// Returns true if the sequence [Begin, End) has N or less items. Can
+/// optionally take a predicate to lazily filter some items
+template <typename IterTy,
----------------
Nit: period.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:1963
+  return hasNItems(std::begin(C), std::end(C), N);
+}
+
----------------
Seems like two patches here, this added function to STLExtras seems to be the only thing relevant for the MLIR part. Can you split this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82232/new/

https://reviews.llvm.org/D82232





More information about the llvm-commits mailing list