[PATCH] D81909: [WebAssembly] Fix bug in FixBrTables and use branch analysis utils

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 15:46:43 PDT 2020


MaskRay added a comment.

In D81909#2104714 <https://reviews.llvm.org/D81909#2104714>, @aheejin wrote:

> In D81909#2099263 <https://reviews.llvm.org/D81909#2099263>, @MaskRay wrote:
>
> > Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:
> >
> >   arcfilter () {
> >           arc amend
> >           git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
> >   }
> >   
> >
> > `Reviewed By: ` is considered important by some people. Please keep the tag. (I have updated my script to use `--date=now` (setting author date to committer date))
> >
> > `https://reviews.llvm.org/D80978` contains a git pre-push hook to automate this.
>
>
> @MaskRay How do I get "Reviewed By:" line? I use `arc diff` but it only puts `Reviewers:` line. And we don't know who is gonna review the CL until we actually get it.


`arc amend` will amend the git description with `Reviewed By:` among other tags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81909/new/

https://reviews.llvm.org/D81909





More information about the llvm-commits mailing list