[PATCH] D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 14:42:10 PDT 2020


mtrofin added a comment.

In D82205#2104505 <https://reviews.llvm.org/D82205#2104505>, @knaumov wrote:

> Answering @mtrofin :
>  Although what you suggested is a valid solution, it will go against the point of this whole pass - to enable the checks of inliner's inner works for all builds, not just the debug ones. If we apply your solution, then still we will get several builds which will avoid being checked due to the conditioning flags.


Ah - and we don't seem to have non-debug build bots with LLVM_ENABLE_DUMP enabled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82205/new/

https://reviews.llvm.org/D82205





More information about the llvm-commits mailing list