[PATCH] D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 13:04:31 PDT 2020


apilipenko added a comment.

@mtrofin, I think it makes sense to have these tests available in all configurations. We have a bunch of printer passes which are not conditioned by NDEBUG.



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:2197
 LLVM_DUMP_METHOD void InlineCostCallAnalyzer::dump() {
 #define DEBUG_PRINT_STAT(x) dbgs() << "      " #x ": " << x << "\n"
   if (PrintInstructionComments)
----------------
Please, avoid duplication and call print here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82205/new/

https://reviews.llvm.org/D82205





More information about the llvm-commits mailing list