[PATCH] D81682: [PGO] Extend the value profile buckets for mem op sizes.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: compiler-rt/include/profile/InstrProfData.inc:836
+INSTR_PROF_VISIBILITY INSTR_PROF_INLINE uint64_t
+InstrProfValueProfMemOpMapValueToRangeRepValue(uint64_t Value) {
+  if (Value <= 8)
----------------
The name of the interface is too long. 

InstrProfGetRangeRepValue would be good enough.


================
Comment at: compiler-rt/include/profile/InstrProfData.inc:855
+INSTR_PROF_VISIBILITY INSTR_PROF_INLINE unsigned
+InstrProfValueProfMemOpIsInOneValueRange(uint64_t Value) {
+  if (Value <= 8)
----------------
InstrProfIsSingleValRange(uint64_t RepValue)


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:620
   } else {
+    // FIXME: This code is to be removed after switching to the new memop value
+    // profiling.
----------------
this branch can be merged with the above -- though it is to be deprecated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81682/new/

https://reviews.llvm.org/D81682