[PATCH] D82183: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 08:40:26 PDT 2020


david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/gep.ll:173
+; CHECK-LABEL: @ptr_idx_mix_scalar_scalable_vector(
+  %v = getelementptr [2 x i64], [2 x i64]* null, i64 0, <vscale x 2 x i64> zeroinitializer
+  ret <vscale x 2 x i64*> %v
----------------
fpetrogalli wrote:
> Don't you want to test what IR is generated? Mostly for consistency with the other tests. It also helps understanding what is the expected output for GEP mixing fixed vectors, scalars and scalable vectors.
Yes you're right. I missed that for some reason. I'll push up a new patch. Thanks for spotting it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82183/new/

https://reviews.llvm.org/D82183





More information about the llvm-commits mailing list