[PATCH] D82132: [FileCheck, unittest] Improve readability of ExpressionFormat

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked 3 inline comments as done.
thopre added a comment.

In D82132#2102713 <https://reviews.llvm.org/D82132#2102713>, @jhenderson wrote:

> Thanks, it's a big diff, but I think I followed it and am happy with the new logic (I didn't try to make sure it matched the old stuff, but I don't think that's strictly necessarily in this case). LGTM, but maybe give it a few days to give others a chance to chime in if they want.


I split the test and then rewrote progressively check by check so nothing should be missing. I've only removed the InvalidTenStr bit because it was not actually tested. There is a test for G which already test invalid char hex digit, which I think came when I realized it was simpler because it didn't require an if condition. So as much testing as before and a bit more (INT64_MIN and INT64_MAX)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82132/new/

https://reviews.llvm.org/D82132