[PATCH] D81364: AMDGPU Initializes StackPtrOffset when NonSpillStackObjects present

Fri Jun 19 06:27:06 PDT 2020

arsenm added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:463
+  // initialize SP in case it is required.
+  if (MF.getFrameInfo().hasCalls() || MFI->hasNonSpillStackObjects()) {
     Register SPReg = MFI->getStackPtrOffsetReg();
----------------
arsenm wrote:
> dstuttard wrote:
> > Is there a way to finesse this so it's only added when it is likely to be required?
> > 
> This isn't really right either. hasNonSpillStackObjects isn't accurate, since we can access with an soffset of 0 in the entry point. This also will fail to catch cases with variable allocas. I think the logic here should probably be hasFP()?
I think this really is hasFP based on the implementation of getFrameRegister

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81364/new/

https://reviews.llvm.org/D81364