[PATCH] D82172: Install llvm-readelf instead of llvm-readobj

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
arichardson added reviewers: jhenderson, grimar.
Herald added subscribers: llvm-commits, rupprecht, MaskRay, mgorny.
Herald added a project: LLVM.

I would like to install llvm-readelf as part of a toolchain install
with -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON. However, llvm-readelf is currently
a symlink to llvm-readobj. llvm-readelf uses the GNU compatible output
style, whereas llvm-readobj is mostly used for testing.
This commit changes llvm-readobj to be a symlink to llvm-readelf so we can
create a -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON installation that has a readelf
binary but does not include llvm-readobj.

See D82170 <https://reviews.llvm.org/D82170>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82172

Files:
  llvm/cmake/modules/AddLLVM.cmake
  llvm/tools/llvm-readobj/CMakeLists.txt


Index: llvm/tools/llvm-readobj/CMakeLists.txt
===================================================================
--- llvm/tools/llvm-readobj/CMakeLists.txt
+++ llvm/tools/llvm-readobj/CMakeLists.txt
@@ -10,7 +10,7 @@
   DebugInfoPDB
   )
 
-add_llvm_tool(llvm-readobj
+add_llvm_tool(llvm-readelf
   ARMWinEHPrinter.cpp
   COFFDumper.cpp
   COFFImportDumper.cpp
@@ -25,8 +25,8 @@
   XCOFFDumper.cpp
   )
 
-add_llvm_tool_symlink(llvm-readelf llvm-readobj)
+add_llvm_tool_symlink(llvm-readobj llvm-readelf)
 
 if(LLVM_INSTALL_BINUTILS_SYMLINKS)
-  add_llvm_tool_symlink(readelf llvm-readobj)
+  add_llvm_tool_symlink(readelf llvm-readelf)
 endif()
Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -1048,7 +1048,6 @@
     llvm-objdump
     llvm-rc
     llvm-readelf
-    llvm-readobj
     llvm-size
     llvm-strings
     llvm-strip


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82172.271982.patch
Type: text/x-patch
Size: 967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200619/10ac8b00/attachment.bin>