[PATCH] D82170: Install llvm-readelf as part of -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 03:11:58 PDT 2020


arichardson created this revision.
arichardson added reviewers: jhenderson, grimar.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

While llvm-readobj is not part of the normal toolchain llvm-readelf is
compatible with GNU readelf and installing it can be useful.
However, I was not able to add llvm-readelf without also installing
llvm-readobj. This can probably be solved by renaming the main CMake target
to be llvm-readelf and have llvm-readobj as a symlink instead.
Should I also try to make this change to avoid installing llvm-readobj or
is the current approach fine?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82170

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -1047,6 +1047,8 @@
     llvm-objcopy
     llvm-objdump
     llvm-rc
+    llvm-readelf
+    llvm-readobj
     llvm-size
     llvm-strings
     llvm-strip
@@ -1061,6 +1063,7 @@
     nm
     objcopy
     objdump
+    readelf
     size
     strings
     strip


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82170.271977.patch
Type: text/x-patch
Size: 441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200619/c749874f/attachment.bin>


More information about the llvm-commits mailing list