[PATCH] D82132: [FileCheck, unittest] Improve readability of ExpressionFormat

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 00:29:54 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Thanks, it's a big diff, but I think I followed it and am happy with the new logic (I didn't try to make sure it matched the old stuff, but I don't think that's strictly necessarily in this case). LGTM, but maybe give it a few days to give others a chance to chime in if they want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82132/new/

https://reviews.llvm.org/D82132





More information about the llvm-commits mailing list