[PATCH] D80978: Add a git hook script that can be manually setup to run some checks on every push
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 22:20:14 PDT 2020
mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.
================
Comment at: llvm/utils/git/pre-push.py:146
+def get_revs_to_push(range):
+ commits = git('rev-list', range).splitlines()
+ # Reverse the order so we print the oldest commit first
----------------
MaskRay wrote:
> return reversed(...)
Actually I need to revert back to `commits.reverse()` here:
```
File ".git/hooks/pre-push", line 165, in handle_push
if len(revs) > 1:
TypeError: object of type 'list_reverseiterator' has no len()
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80978/new/
https://reviews.llvm.org/D80978
More information about the llvm-commits
mailing list