[PATCH] D82123: [PGO] Add a functionality to always instrument the func entry BB

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 20:54:05 PDT 2020


On Thu, Jun 18, 2020 at 3:22 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> ok. Why atomic update just for first entry? are they particularly more
> contended than other counters?
>
I don't think they have more contention than other counters.
They are more important than other counters as the entry count is the base
for profile count in BFI.
Previously I have done some work to verify the BFI using profile count. I
think that helped (but it slows down the instrumentation a lot)

>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D82123/new/
>
> https://reviews.llvm.org/D82123
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200618/eec66437/attachment.html>


More information about the llvm-commits mailing list