[PATCH] D81631: Fix undefined behavior in Dwarf.
zuojian lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 17:31:45 PDT 2020
linzj added a comment.
In D81631#2101784 <https://reviews.llvm.org/D81631#2101784>, @dblaikie wrote:
> Could you include a comment in the test case explaining how this IR differs from all the IR clang usually generates? (in general what's interesting about this IR)
>
> Also - remove the "valgrind" usage from that llc invocation (test machines might not have valgrind, etc - does UBSan/ASan/MSan catch this? There are buildbots that'll run the tests with sanitizers like those enabled & it'd be good if the test could catch a regression at least on those buildbots) - and include some testing of the behavior of llc (ie: what behavior do we get instead of UB? Presumably there's some specific behavior we're expecting beyond "anything other than crashing")
It just a simple function complied by clang with -g. No modification.
I don't known how to write a test case that tell the try not to build the LLC with ubsan, could you give me an example?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81631/new/
https://reviews.llvm.org/D81631
More information about the llvm-commits
mailing list