[PATCH] D82132: [FileCheck, unittest] Improve readability of ExpressionFormat

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 16:26:55 PDT 2020


thopre created this revision.
thopre added reviewers: jhenderson, jdenny, probinson, grimar, arichardson.
thopre added a project: LLVM.

Factor out repetetitive code into helper function and split massive
ExpressionFormat method test into separate test for each method,
removing dead code in passing. Also add a MinInt64 and MaxInt64 checks
when testing getMatchingString.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82132

Files:
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82132.271871.patch
Type: text/x-patch
Size: 14024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200618/81411092/attachment.bin>


More information about the llvm-commits mailing list