[PATCH] D81925: [AMDGPU] Select s_cselect
Piotr Sobczak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 15:21:49 PDT 2020
piotr marked an inline comment as done.
piotr added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5565
+ for (MachineInstr &CandI :
+ make_range(std::next(MachineBasicBlock::reverse_iterator(Inst)),
+ Inst.getParent()->rend())) {
----------------
arsenm wrote:
> Maybe add a search range limit?
Not sure - the code relies on finding SCC def, and by construction (.td pattern) the def is very close to S_CSELECT's implicit use anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81925/new/
https://reviews.llvm.org/D81925
More information about the llvm-commits
mailing list