[llvm] ae5adb8 - AMDGPU: Update private null pointer value in documentation
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 14:27:27 PDT 2020
Author: Matt Arsenault
Date: 2020-06-18T17:27:19-04:00
New Revision: ae5adb8da561fa4dd59915e4c97358278fb610a9
URL: https://github.com/llvm/llvm-project/commit/ae5adb8da561fa4dd59915e4c97358278fb610a9
DIFF: https://github.com/llvm/llvm-project/commit/ae5adb8da561fa4dd59915e4c97358278fb610a9.diff
LOG: AMDGPU: Update private null pointer value in documentation
Private pointers used to workaround IR semantics by artifically
reserving an object at offset 0 so no user object would be allocated
there. Since alloca now uses a non-0 address space, that workaround is
unnecssary and 0 can be treated as a valid pointer.
Added:
Modified:
llvm/docs/AMDGPUUsage.rst
Removed:
################################################################################
diff --git a/llvm/docs/AMDGPUUsage.rst b/llvm/docs/AMDGPUUsage.rst
index 99a93d7c0ce2..f97d6d75b9f8 100644
--- a/llvm/docs/AMDGPUUsage.rst
+++ b/llvm/docs/AMDGPUUsage.rst
@@ -365,8 +365,8 @@ supported for the ``amdgcn`` target.
Region 2 N/A GDS 32 *not implemented for AMDHSA*
Local 3 group LDS 32 0xFFFFFFFF
Constant 4 constant *same as global* 64 0x0000000000000000
- Private 5 private scratch 32 0x00000000
- Constant 32-bit 6 *TODO*
+ Private 5 private scratch 32 0xFFFFFFFF
+ Constant 32-bit 6 *TODO* 0x00000000
Buffer Fat Pointer (experimental) 7 *TODO*
================================= =============== =========== ================ ======= ============================
More information about the llvm-commits
mailing list