[PATCH] D81319: [Dexter] Add --source-dir-root flag

[David Blaikie via llvm-commits]

*reads back*

Oh, yeah - fair enough!

On Thu, Jun 18, 2020 at 12:10 PM Eric Christopher via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> In this case it looked like both reviewers had said lgtm, but hadn't actually hit the button :)
>
> On Thu, Jun 18, 2020 at 10:54 AM David Blaikie via Phabricator <reviews at reviews.llvm.org> wrote:
>>
>> dblaikie added a comment.
>>
>> In D81319#2099642 <https://reviews.llvm.org/D81319#2099642>, @tbosch wrote:
>>
>> > @TWeaver @jmorse It looks like both of you gave an implicit LGTM, is that correct?
>> >
>> > I will wait one more day then submit this change so that it doesn't bit rot.
>>
>>
>> (aside: Generally once something's been sent for review it should not be committed until approved (otherwise it muddies the waters a bit - it was sent for review because the author felt it needed review, but then committed without it?))
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D81319/new/
>>
>> https://reviews.llvm.org/D81319
>>
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits