[PATCH] D81050: [llvm-exegesis] Let Counter returns up to 16 entries.

Ondrej Sykora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 12:34:32 PDT 2020


ondrasej added a comment.

One last comment, but otherwise this looks good. I'll leave the approval to Clement.



================
Comment at: llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp:76
+  llvm::SmallVector<int64_t, 4> AccumulatedValues;
+  double MinVariance = std::numeric_limits<double>::max();
   const char *CounterName = State.getPfmCounters().CycleCounter;
----------------
Very nit: if we're working with doubles, std::numeric_limits<double>::infinity() might be even better. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81050/new/

https://reviews.llvm.org/D81050





More information about the llvm-commits mailing list