[PATCH] D81682: [PGO] Extend the value profile buckets for mem op sizes.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 11:27:12 PDT 2020


yamauchi added inline comments.


================
Comment at: compiler-rt/include/profile/InstrProfData.inc:813
+ *   [4, 4]
+ *   [5, 5]
+ *   [6, 6]
----------------
davidxl wrote:
> should 5,6, and 7 be merged into one range?
This is as intended because some mem ops could have separate code paths for 5, 6, and 7 (at least our memcmp does in fact) and because the old buckets were 0-9 individually. I'd like the new buckets to be flexible to accommodate those and to supercede the old buckets.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81682/new/

https://reviews.llvm.org/D81682





More information about the llvm-commits mailing list