[PATCH] D81319: [Dexter] Add --source-dir-root flag
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 10:54:14 PDT 2020
dblaikie added a comment.
In D81319#2099642 <https://reviews.llvm.org/D81319#2099642>, @tbosch wrote:
> @TWeaver @jmorse It looks like both of you gave an implicit LGTM, is that correct?
>
> I will wait one more day then submit this change so that it doesn't bit rot.
(aside: Generally once something's been sent for review it should not be committed until approved (otherwise it muddies the waters a bit - it was sent for review because the author felt it needed review, but then committed without it?))
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81319/new/
https://reviews.llvm.org/D81319
More information about the llvm-commits
mailing list