[PATCH] D82100: [AIX] Split lit test shtest-format into two separate tests and add AIX as UNSUPPORTED for shtest-format-argv0

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 09:13:28 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-format-argv0/lit.cfg:8
+config.target_triple = 'x86_64-unknown-unknown'
+config.substitutions.append(('%{python}', '"%s"' % (sys.executable)))
----------------
I think there's no use of this substitution in the directory.


================
Comment at: llvm/utils/lit/tests/shtest-format-argv0.py:6
+#
+# This test is not supported on AIX because `[` is only available as a shell-builtin.
+# UNSUPPORTED: aix
----------------
Minor nit: "builtin" is a noun here. s/shell-builtin/shell builtin/;



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82100/new/

https://reviews.llvm.org/D82100





More information about the llvm-commits mailing list