[PATCH] D81925: [AMDGPU] Select s_cselect

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Can you also add a MIR test that at least covers the undef case?



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5565
+    for (MachineInstr &CandI :
+         make_range(std::next(MachineBasicBlock::reverse_iterator(Inst)),
+                    Inst.getParent()->rend())) {
----------------
Maybe add a search range limit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81925/new/

https://reviews.llvm.org/D81925