[PATCH] D81914: [AMDGPU] Avoid use of V_READLANE into EXEC in SGPR spills

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 08:40:46 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7034-7035
+    for (unsigned i = 0; i < 2; ++i) {
+      Register DstReg = MI.getOperand(i % 2).getReg();
+      Register SrcReg = MI.getOperand((i + 1) % 2).getReg();
+      if (SrcReg.isVirtual()) {
----------------
This is now way more complicated. You shouldn't need to loop, or consider specific physical registers. You should be apply to just change the register classes that were used here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81914/new/

https://reviews.llvm.org/D81914





More information about the llvm-commits mailing list