[PATCH] D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2940
+    TypePromotionTransaction::ConstRestorationPt Point) {
+  return (!Actions.empty() && Point != Actions.back().get());
+}
----------------
You don't need the outer parens.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:4955
   if (!AddrModes.combineAddrModes()) {
-    TPT.rollback(LastKnownGood);
-    return false;
+    return TPT.changed(LastKnownGood);
   }
----------------
The commit message suggests you're just fixing the return value from optimizeMemoryInst, but this change (not rolling back) looks like a change in behaviour. Can you explain?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81256/new/

https://reviews.llvm.org/D81256