[PATCH] D81515: [llvm] Release-mode ML InlineAdvisor
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 07:02:44 PDT 2020
mtrofin marked 2 inline comments as done.
mtrofin added inline comments.
================
Comment at: llvm/cmake/modules/TensorFlowCompile.cmake:24
+ --output_prefix ${prefix}
+ --cpp_class ${cpp_class}
+ )
----------------
asl wrote:
> mtrofin wrote:
> > asl wrote:
> > > This misses the target triple. Otherwise even on MacOS it will generate linux object file.
> > Thanks! Fixed.
> Host triple should be used here, no?
Done - thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81515/new/
https://reviews.llvm.org/D81515
More information about the llvm-commits
mailing list